Allow config options to be an enum. #3494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use it for 'security.prompt.level'.
mitchell-as
force-pushed
the
mitchell/dx-2927
branch
from
d9cce92
to
a630247
Compare
MDrakos
requested changes
Sep 19, 2024
internal/runners/config/set.go
Outdated
| @@ -52,6 +55,14 @@ func (s *Set) Run(params SetParams) error { | |||
| if err != nil { | |||
| return locale.WrapInputError(err, "Invalid integer value") | |||
| } | |||
| case configMediator.Enum: | |||
| enums := option.Default.(*configMediator.Enums) | |||
There was a problem hiding this comment.
I believe this is a potential panic if the type check fails. We should add an ok check here.
There was a problem hiding this comment.
I had more faith in us, but very well, I've added a check :)
MDrakos
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use it for 'security.prompt.level'.